Reserved Slot Management [1.0.0.0 31 July] [BC2]

[ImportBot]

Originally Posted by Zaeed*:

 

Basic infomation:

This plugin is designed to place players currently in the server, onto the Reserved Slot list. This should ensure that they are not kicked when a player already on the list joins.

 

Installation:

- Extract CReservedSlotManagementBeta.cs into plugin directory.

Or just install from the Packages Tab in procon

 

Current version:

0.0.0.1

 

Download:

 

 

 

Changelog:

0.0.0.1

- Initial release.

1.0.0.0

- Remove players from list when plugin disabled.

- Added option to add people to the list after a certain amount of time.

 

 

Thanks to:

Phogue for Procon

 

Description:

Description will come when the plugin comes out of BETA

[ImportBot]

Originally Posted by Zaeed*:

 

Please test this out with your clan tags.

 

The ability to add players based on score and time played on the server will be coming soon. I wanted to get this version out asap for testing.

[ImportBot]

Originally Posted by stuckmoto*:

 

Installing today! The guys will love this!

So members that are already on the list won't be kicked from server for VIP member joining?

[ImportBot]

Originally Posted by Plasmatique*:

 

Zaeed, cheers for this, you're the greatest!

 

Now, I haven't tried it yet, but does it support multiple clantags? Cause we use clantags for recruits, members, admins, and so forth.

 

Cheers for this!!!!

 

EDIT: Just saw the plugin, multiple clan tags are possible.

[ImportBot]

Originally Posted by Plasmatique*:

 

Ok, sorry for the double post, but it helps continuality...

 

I tried the plugin and it is not 100% accurate...at least not for me.

I can explain easier on voice chat, but I'll try to explain it on here.

 

The testing environment:

- A ranked conquest server with max 8 slots.

- 9 communitymembers from different layers of the command structure

- layered procon with no plugins running, besides CReservedSlotManagementBeta

 

ReservedSlotManagement = RSM

Situations:

- regular system: reserved slot list with all on the list, wolfcon running with 1 player not on it. Player not on wolfcon gets kicked time and time again, no others were kicked.

- RSM online: no clantags added to the RSM list. players not on the reserved slot list in procon get kicked, people on it, don't. So it works for the actual list built into procon.

- RSM online: 1 out of 4 clantags added. players on built in list are not kicked, players without the added tag on RSM and not on built in list get kicked.

- RSM online: all clantags added. players on the built in list get kicked. people on the RSM list get kicked.

- RSM offline, then online again: all clantags added. people stay in queue, no matter what I change in the built in list as well as the actual plugin.

- RSM offline after being online: players stay in queue even tho they are on the reserved list....Restarted procon server and RSM still offline, people get kicked no matter what. Reserved slot list is not working properly, some stay in queue while on the list and some people get the slot while they are not on the list...

 

So in short, it's not 100% yet I reckon or maybe it's me. Keep at it please

 

If you need a tester or a server to test it on, gimme a shout!!!

[ImportBot]

Originally Posted by Zaeed*:

 

You can't go switching it on and off again.. That's like dividing by zero, or asking phogue why procon2 isn't ready.

 

When the plugin first starts, it reads the reserved slot list and checks who is on the list. It then excludes those people from any operations.

 

It does this so that whoever you already have on your list doesn't get removed from the Reserved Slot list when they leave the server.

 

So:

Initially on Reserved List

Bob

Frank

 

 

Bob has tag [tag]

Frank has tag [gat]

Steve has tag [procon2]

Jeff has tag [android]

 

For argument sake, its a 3 player only server.

 

Case 1: (No tags set)

Bob, Jeff, and Steve join the server.

Frank tries to join the server. Either Jeff or Steve get kicked. So thats a normal situation.

 

Case 2: ([procon2] set in plugin)

Bob, Jeff and Steve join the server.

The plugin adds Steve to the list, because of this tag.

Frank tries to join, Jeff gets kicked.

Steve leaves the server, his name gets removed from the Reserved list

Bob leaves the server, his name stays on the list.

 

Now what you're doing wrong is you're turning off the plugin before people leave. So when it starts back up, anybody added will still be there, and thus they will stay there.

 

I'll add some code to remove people when the plugin is disabled which should prevent this.

[ImportBot]

Originally Posted by Plasmatique*:

 

Well, the situations I put earlier were in that order...so when the plugin had been on from the beginning it happened that, for some reason, it didn't "discriminate" anymore; players were kicked regardless of being on the built in list or added through the plugin. So I figured, let's see what happens when I turn it off and on again, since it was already "broken".

Please understand that I have no intention of saying something bad about the plugin or your work...trust me, I've waited 10 months for someone to get this show on the road

All I'm trying to do is post my findings as accurate as possible and to make sure as much of information and situations are given so you can improve this plugin.

Again, we wouldn't mind at all to donate 20-30 bucks to a goal to your liking (being your own pocket or phogue or whatever).

If you need people to test or servers to test, gimme a shout!

[ImportBot]

Originally Posted by Zaeed*:

 

Well, the situations I put earlier were in that order...so when the plugin had been on from the beginning it happened that, for some reason, it didn't "discriminate" anymore; players were kicked regardless of being on the built in list or added through the plugin. So I figured, let's see what happens when I turn it off and on again, since it was already "broken".

Please understand that I have no intention of saying something bad about the plugin or your work...trust me, I've waited 10 months for someone to get this show on the road

All I'm trying to do is post my findings as accurate as possible and to make sure as much of information and situations are given so you can improve this plugin.

Again, we wouldn't mind at all to donate 20-30 bucks to a goal to your liking (being your own pocket or phogue or whatever).

If you need people to test or servers to test, gimme a shout!

Screw phogue.. give me moar money

 

On a serious note, I wasn't having a go at you, far from it, so don't worry..

 

The fact that it was kicking everybody is a bit odd..

 

Were you looking at the Reserved slot list to see who was being added to it when people joined?

And when it was kicking anyone, did you confirm that the people being kicked were on the list?

[ImportBot]

Originally Posted by Phil_K*:

 

Hi.

 

The fact that it was kicking everybody is a bit odd..

No it's not. Well, as long as the reservedSlot-List function is disabled

for the server done by the ISP.

 

To check if the reservedSlot is actively checked by the server do the following

command on the console tab:

Code:

serverInfo

You should get something like

Code:

OK (DE) FFM -- Gilgamesch 0 22 CONQUEST Levels/MP_012CQ 2 2 2 200 200 0 AcceptingPlayers true true false 235962 984 BC2 8 195.122.135.158:19567 v1.826 | A1382 C2.272 true EU

Focus on the second last argument: "true".

This means on my server the reservedSlots function is active.

If this is "false" than the resevedSlot list is totally ignored by the server.

 

That setting can only be changed by your GSP.

 

Greets

Phil.

[ImportBot]

Originally Posted by Plasmatique*:

 

Were you looking at the Reserved slot list to see who was being added to it when people joined?

And when it was kicking anyone, did you confirm that the people being kicked were on the list?

Yes and yes. The people who were getting kicked were on the list.

Also, we're using the reserved slots for admins and VIPs (paying members/players), but I want my clanmembers to be safe when they are on the server (whitelisted). Just for the sake of argument, is it possible for you to make something similar to this (with the clantags being protected) but not involve the reserved slots list? Sort of what Wolfcon did with the communitybuilder? Even if it would mean we would need to enter the seperate names (which is a pain in the ass for any clan with 100+ members, and we got 400+), I would already be grateful, simply cause it will eliminate the mandatory use of Wolfcon at the moment.

Thanks in advance!

 

@Phil, the trouble is that it works fine beforehand, then "screws up" along the way. Now, I'm still not a 100% that it wasn't me doing something stupid

[ImportBot]

Originally Posted by Phil_K*:

 

Hi

 

@Phil, the trouble is that it works fine beforehand, then "screws up" along the way. Now, I'm still not a 100% that it wasn't me doing something stupid

Well, don't get me wrong. I believe what you say, but...

Please do me a favor and post the complete reply you get on a serverInfo command

using the console tab.

 

The reason is, i was in contact with some others whose GSP changed the master setting

for the JoinQueue and for some reason the server had gone mad not letting someone

in as it was full but telling them they are in the queue. The serverInfo showed the joinQueue

as disabled. After restarting the gameserver situation normalized.

 

Greets

Phil.

[ImportBot]

Originally Posted by Zaeed*:

 

Just for the sake of argument, is it possible for you to make something similar to this (with the clantags being protected) but not involve the reserved slots list? Sort of what Wolfcon did with the communitybuilder? Even if it would mean we would need to enter the seperate names (which is a pain in the ass for any clan with 100+ members, and we got 400+), I would already be grateful, simply cause it will eliminate the mandatory use of Wolfcon at the moment.

There is no other way that I am aware of.

 

The plugin protects anyone that is on the list when you enable the plugin, and simply adds people when they join and removes them when they leave.

 

The reason for this is because when your server is full, it is people that are on the Reserved list that are protected. There isn't any other way to say yay or nay to who gets kicked.

 

I've made a few changes, and i'll upload version 0.0.0.2 soon.

[ImportBot]

Originally Posted by Zaeed*:

 

Update:

Version 1.0.0.0

 

Changes:

- Removes players from the list if you disable the plugin.

- Added an option to add people to the list after a certain amount of time

[ImportBot]

Originally Posted by nbtc971*:

 

Love it.. will be testing it out.

[ImportBot]

Originally Posted by jfc12468-gmail-com*:

 

There is one thing stopping me from installing this on my clans server.

The way it decides who to kick, I do not like random, If you would offer a lastjoiner option I would install this today.

[ImportBot]

Originally Posted by Zaeed*:

 

You can't control that, as it is handled on the server side.

 

The best you can do is set a certain time, say 60 minutes, and then have only the people that have been on less than the 60 minutes kicked.

[ImportBot]

Originally Posted by Ike*:

 

The inbuilt reserved slot system, kicks the last non "VIP" player to join the server, its not random

 

Edit: Morph is calling me a liar on this one, but im sure its in the docs

[ImportBot]

Originally Posted by Zaeed*:

 

The inbuilt reserved slot system, kicks the last non "VIP" player to join the server, its not random

 

Edit: Morph is calling me a liar on this one, but im sure its in the docs

I call you a liar too.

 

You however just gave me an idea to have a mode that adds everyone to the reserved slot list, except for the last joiner.. Which will effectively force it to only kick the last joiner.

[ImportBot]

Originally Posted by Phil_K*:

 

Hi.

 

The inbuilt reserved slot system, kicks the last non "VIP" player to join the server, its not random

Edit: Morph is calling me a liar on this one, but im sure its in the docs

I'm not calling anyone a liar but sometimes observed behavior randomly seems to

be regular even if it does what the documentation shows...

 

.. and that is (R-32, Page 5&6):

VIP players, reserved slots, and the join queue

Older versions of the BFBC2 PC servers had a system where slots could be reserved permanently.

This has been abandoned in favor of a kick-on-demand system (similar to that of BFBC2).

In addition, there is a join queue.

 

NOTE: In some locations which are far away from USA, bugs in the join queue code can cause crashes. One such example is Taiwan. Due to this, some RSPs have (after discussions with DICE) decided to turn off the join queue for all servers in those regions. The server administrator cannot control the setting of the join queue.

 

Defining VIP players

The server has an internal list of VIP players. Upon startup, the server reads it from a file named reservedslotslist.txt. The list of VIP players can also be edited on-the-fly through the use of the reservedSlots.* commands.

 

The list of VIP players can contain up to 500 entries.

 

When a non-VIP player joins a server…

If there are slots left, the player will be able to join directly.

 

Otherwise, the player is placed in a join queue, if enabled. ("You are person 3 out of 3 in the queue for this server.") If the join queue is disabled or full, the player is told that the server is full.

 

When a VIP player joins a server…

If there are slots left, the player will be able to join directly – just like a non-VIP player.

 

If there are no slots left, and the join queue is enabled, the server will randomly choose a non-VIP player, and kick him/her to make room for the VIP player.

 

If the server happens to be full of other VIP players, and the join queue is enabled, then the VIP player will be placed in a join queue.

 

If the server happens to be full of other VIP players, and the join queue is disabled, then the VIP player will be told that the server is full.

I have no information about how that "random" algorithm is working maybe there is

indeed some situation in which it will choose a just entered non-VIP player instead of

being real random.

 

Greets

Phil.

[ImportBot]

Originally Posted by nbtc971*:

 

After testing this for a while now I will have to disable it. I'm seeing what I think one of the other posters is seeing. We allow visitors to purchase reserved slots. When they do we obviously add their soldier name to the reserved slot list manually. However when running this plugin, it will remove everyone from the list, including those the plugin didn't handle. My guess is that if they were manually added to the reserved slot list, then they show up on the server, once they leave, it removes them as it was intended. This is merely a guess and I would think to fix it you would only have to add a check when someone joins to see if their name is already on the list, and if so, don't bother adding it.

 

As I said, I will have to disable this plugin for now until this issue is resolved. I hope my feedback helps.

[ImportBot]

Originally Posted by Zaeed*:

 

After testing this for a while now I will have to disable it. I'm seeing what I think one of the other posters is seeing. We allow visitors to purchase reserved slots. When they do we obviously add their soldier name to the reserved slot list manually. However when running this plugin, it will remove everyone from the list, including those the plugin didn't handle. My guess is that if they were manually added to the reserved slot list, then they show up on the server, once they leave, it removes them as it was intended. This is merely a guess and I would think to fix it you would only have to add a check when someone joins to see if their name is already on the list, and if so, don't bother adding it.

 

As I said, I will have to disable this plugin for now until this issue is resolved. I hope my feedback helps.

It won't remove them if they were on the list when the plugin started.

If you want to add someone manually to the list, its best if either they're not in the server, or you disable the plugin, and then add them.

[ImportBot]

Originally Posted by nbtc971*:

 

They were already in the list before I ever loaded the plugin. Not sure how else they would of disappeared, as I've never had problems in the past.

[ImportBot]

Originally Posted by Zaeed*:

 

There is only one situation that could happen, and thats if they were in the server, and left the instant you enabled the plugin.

 

I've patched that, however I doubt thats your problem.

 

What was this players name?

 

Has it happened to anyone else?

[ImportBot]

Originally Posted by nbtc971*:

 

Yes.. it happened to several people.. around 5 or 6. I will try to get more details tomorrow, i'm off to bed.

[ImportBot]

Originally Posted by stuckmoto*:

 

Zaeed - it happened to one of our servers too. Only 1 out of 4 servers. May have happened before your patch. No big deal, we only have about 25 on the list. Looks like the active guys got removed. I'll watch for a occurrence.

[ImportBot]

Originally Posted by nbtc971*:

 

Here are some names of people who were removed mysteriously...

 

BikerDog

theHman

TheCrimsonStar

SgtClone

Boo_Yaa41

 

Maybe your code doesn't like camel case.

[ImportBot]

Originally Posted by Zaeed*:

 

Are you both using version 1.0.0.0?

[ImportBot]

Originally Posted by stuckmoto*:

 

I'm @ work right now... when I get home I'll check

 

~edit - yes 1.0.0.0

[ImportBot]

Originally Posted by nbtc971*:

 

I'm using the latest and greatest.

[ImportBot]

Originally Posted by Zaeed*:

 

And these people were on the Reserved Slot list BEFORE the plugin was enabled..

 

and the plugin wasn't turned on and off really quickly..

 

They weren't removed manually?

 

I really don't know.. Its not possible for that to happen..