Advanced In-Game Admin and Ban Enforcer - AdKats

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

I got it going finally after rebuilding my databases and MySQL for that server.

Rather drastic solution to get things working again, something else must have been the issue. We've been able to keep our records/data since version 1.7 without losing anything.

[ImportBot]

Originally Posted by jking54*:

 

Rather drastic solution to get things working again, something else must have been the issue. We've been able to keep our records/data since version 1.7 without losing anything.

Yes of course but only reason I did that was that it never really got much action anyhow before I deactivated it and all I did was delete the database and phpMyAdmin and reinstall both, no biggie. One other thing, it seems to be disabled after restarting procon, what may be the issue?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

New user system is nearing completion. I should have a test version out tomorrow for basics, still need to finish the other facets.

[ImportBot]

Originally Posted by www-battleplay4u-com*:

 

will it solve my problem to not write datas into database?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

will it solve my problem to not write datas into database?

The database structure has been completely revamped, so it will at least give a fresh start, which might fix your particular issue.

[ImportBot]

Originally Posted by kcuestag*:

 

Is there a way of not using the BF4 Stats Logger database? I don't want it to mess my chat table (for web stats).

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Is there a way of not using the BF4 Stats Logger database? I don't want it to mess my chat table (for web stats).

Run this to fix your issue until 4.0 is released:

 

ALTER TABLE `tbl_chatlog` DROP FOREIGN KEY `tbl_chatlog_ibfk_player_id`;

ALTER TABLE `tbl_chatlog` CHANGE COLUMN `logPlayerID` `logPlayerID` INT(10) AFTER logMessage;

 

If this errors out, try running only the second line.

 

The issue is your web-stats page is using a "Select *" Which is miscounting the columns after the new one was added. This moves the column i added to the very end, so your page should work properly after this.

[ImportBot]

Originally Posted by www-battleplay4u-com*:

 

The database structure has been completely revamped, so it will at least give a fresh start, which might fix your particular issue.

cool

[ImportBot]

Originally Posted by PapaCharlie9*:

 

I just noticed this in the start-up sequence of plugins for Procon:

 

Code:

[16:37:40] Loading xVotemap... Loaded
[b][16:37:40] [AdKats] Waiting a few seconds for requirements and other plugins to initialize, please wait...[/b]
[16:37:42] AdaptiveServerSize: Enabled!
[16:37:45] Basic In-Game Info Enabled!
[16:37:45] PRoCon Chat, GUID and Stats Logger Enabled
[16:37:45] PRoCon Chat, GUID and Stats Logger: Floodprotection set to 10 Request per Round for each Player
[16:37:45] [AdKats] Initializing AdKats 3.7.0.1 components.
[16:37:45] [AdKats] SUCCESS: Server IP is 94.250.195.42:47200!
[16:37:45] [AdKats] Attempting database connection. Attempt 1 of 5.
[16:37:45] [AdKats] SUCCESS: Database connection open.
[16:37:46] Latency Manager Enabled!
[16:37:46] [AdKats] SUCCESS: Database confirmed functional for AdKats use.
[16:37:46] [AdKats] SUCCESS: Database Server Info Fetched. Server ID is 1!
[b][16:37:46] [AdKats] Enabled! Version: 3.7.0.1[/b]

Wouldn't it make more sense to start the AdKats initialization OnPluginEnabled? It seems odd that all that work is done before the plugin is even enabled. What if the plugin isn't enabled? Is the connection check still done?

 

It can and indeed should be in a separate thread during the call to OnPluginEnabled, so as not to tie up Procon.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

I just noticed this in the start-up sequence of plugins for Procon:

 

Code:

[16:37:40] Loading xVotemap... Loaded
[b][16:37:40] [AdKats] Waiting a few seconds for requirements and other plugins to initialize, please wait...[/b]
[16:37:42] AdaptiveServerSize: Enabled!
[16:37:45] Basic In-Game Info Enabled!
[16:37:45] PRoCon Chat, GUID and Stats Logger Enabled
[16:37:45] PRoCon Chat, GUID and Stats Logger: Floodprotection set to 10 Request per Round for each Player
[16:37:45] [AdKats] Initializing AdKats 3.7.0.1 components.
[16:37:45] [AdKats] SUCCESS: Server IP is 94.250.195.42:47200!
[16:37:45] [AdKats] Attempting database connection. Attempt 1 of 5.
[16:37:45] [AdKats] SUCCESS: Database connection open.
[16:37:46] Latency Manager Enabled!
[16:37:46] [AdKats] SUCCESS: Database confirmed functional for AdKats use.
[16:37:46] [AdKats] SUCCESS: Database Server Info Fetched. Server ID is 1!
[b][16:37:46] [AdKats] Enabled! Version: 3.7.0.1[/b]

Wouldn't it make more sense to start the AdKats initialization OnPluginEnabled? It seems odd that all that work is done before the plugin is even enabled. What if the plugin isn't enabled? Is the connection check still done?

 

It can and indeed should be in a separate thread during the call to OnPluginEnabled, so as not to tie up Procon.

Papa, it IS done OnPluginEnabled . "Enabled!" console message is the confirmation that it finished enabling with no issues. Also, all initialization is done in a separate initialization thread. Nothing in AdKats except OnServerInfo is synchronous with procon, it's all queued to one of the 9 processing threads i run.

 

This is the reason i was wondering about @Morph's worry of having a big plugin "tie up" procon with all of the things it does, since everything in AdKats is async with what procon supplies or sends it. All On* functions pass their info off to thread handlers, it cannot cause panic or lag for procon no matter how much work it ends up doing.

[ImportBot]

Originally Posted by kcuestag*:

 

Run this to fix your issue until 4.0 is released:

 

ALTER TABLE `tbl_chatlog` DROP FOREIGN KEY `tbl_chatlog_ibfk_player_id`;

ALTER TABLE `tbl_chatlog` CHANGE COLUMN `logPlayerID` `logPlayerID` INT(10) AFTER logMessage;

 

The issue is your web-stats page is using a "Select *" Which is miscounting the columns after the new one was added. This moves the column i added to the very end, so your page should work properly after this.

I'm clueless about all that MySQL stuff (Good thing I started studying that this year) so I'll let my host know as he is pretty familiar with MySQL.

 

Thanks, I'll let you know how it goes.

[ImportBot]

Originally Posted by kcuestag*:

 

Run this to fix your issue until 4.0 is released:

 

ALTER TABLE `tbl_chatlog` DROP FOREIGN KEY `tbl_chatlog_ibfk_player_id`;

ALTER TABLE `tbl_chatlog` CHANGE COLUMN `logPlayerID` `logPlayerID` INT(10) AFTER logMessage;

 

The issue is your web-stats page is using a "Select *" Which is miscounting the columns after the new one was added. This moves the column i added to the very end, so your page should work properly after this.

We have an issue. When enabling "Instant Logging of Chat Messages" it forces the plugin to close (And stops logging the chat).

 

Any idea?

 

I may just wait for 4.0 release.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

We have an issue. When enabling "Instant Logging of Chat Messages" it forces the plugin to close (And stops logging the chat).

 

Any idea?

 

I may just wait for 4.0 release.

In AdKats 3.7.0.1 and 3.7.0.2 it performs the chat logging and disables it in stat logger. This is told in the dependency docs.

[ImportBot]

Originally Posted by jking54*:

 

We have an issue. When enabling "Instant Logging of Chat Messages" it forces the plugin to close (And stops logging the chat).

 

Any idea?

 

I may just wait for 4.0 release.

Maybe I'm missing your intent but why log them when they are logged anyhow in procon?

[ImportBot]

Originally Posted by kcuestag*:

 

Maybe I'm missing your intent but why log them when they are logged anyhow in procon?

Because I want them to show in my web stats: http://oaksclan.view-your-stats.com/

 

@ColColonCleaner: Any plans on changing that?

[ImportBot]

Originally Posted by PapaCharlie9*:

 

Papa, it IS done OnPluginEnabled . "Enabled!" console message is the confirmation that it finished enabling with no issues. Also, all initialization is done in a separate initialization thread

Oh, I see. That's what I get for not checking the source code. Most plugins post that message at the beginning of their enable call. I understand why you do it at the end, but it looks weird in the log when all the other plugins are doing it at the beginning. I'd suggest posting the message first, synchronously, then launch the thread and let it go and return. That way, all of the start-up messages will come after the "plugin enabled" standard message, and be less confusing.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Oh, I see. That's what I get for not checking the source code. Most plugins post that message at the beginning of their enable call. I understand why you do it at the end, but it looks weird in the log when all the other plugins are doing it at the beginning. I'd suggest posting the message first, synchronously, then launch the thread and let it go and return. That way, all of the start-up messages will come after the "plugin enabled" standard message, and be less confusing.

Alright i can add another message at the start of the enable process. The difference between AdKats and others is there are so many possible points of failure during initialization (no db settings, no stat logger, setup script wasn't run, no server ID logged...etc..etc..) that it's only truly enabled once all that is done. This is what i noticed with stat logger, when you enable it it says "Enabled!" and then a few seconds later it can proceed to spew errors. I just didn't like that, only say enabled when you are actually enabled, but i'll add a message like "AdKats enabled, beginning startup sequence..." then end with something like "AdKats Running! Version xxxxx"

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Maybe I'm missing your intent but why log them when they are logged anyhow in procon?

? Chat logs in procon are a text file, database logging is faster, more up to date, and much more easy to search. Many web admin/stats pages use it.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Because I want them to show in my web stats: http://oaksclan.view-your-stats.com/

 

@ColColonCleaner: Any plans on changing that?

AdKats 3.7+ needs player IDs in chat logs, mainly for the webadmin but it will be worked into the plugin soon too. AdKats currently takes over the chat logging process when it's running and logs using settings equivalent to the following:

 

Enable Chatlogging? Yes

Log ServerSPAM? Yes

Instant Logging of Chat Messages? Yes

Enable chatlog filter(Regex)? No

 

Because AdKats is doing the logging, if stat logger did it too then all of your chat messages would be duplicated in the database, you would have 2 of everything.

 

All chat logging aspects taken over by AdKats in 3.7 are being removed in 4.0. The only thing remaining will be a single procedure needing to be run on your database, that procedure will handle adding the PlayerIDs to chat logs, the whole reason this happened in the first place.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Taking a little more time with the 4.0 beta release. Making sure things operate according to plan. This includes the new user system, role assignments, new commands, ban enforcer updates, teamswap updates, reserved slot feeder and whitelist feeder, the updated hacker-checker, and external command handler for insane limits/proconrulz. Not to mention all the database changes that go along with that.

 

Edit: The email handler for reports is working now too

[ImportBot]

Originally Posted by Mavy*:

 

Awesome news: looking forward to the new functions. DO you know if the old (1.0.3) webadmin will still work with 4.0?

 

PS: If you need another tester let me know.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Awesome news: looking forward to the new functions. DO you know if the old (1.0.3) webadmin will still work with 4.0?

 

PS: If you need another tester let me know.

It will not work with the old webadmin, almost every database table has been renamed and the columns changed. However, the new webadmin version will be released soon, and it will be open source.

[ImportBot]

Originally Posted by TMiland*:

 

Taking a little more time with the 4.0 beta release. Making sure things operate according to plan. This includes the new user system, role assignments, new commands, ban enforcer updates, teamswap updates, reserved slot feeder and whitelist feeder, the updated hacker-checker, and external command handler for insane limits/proconrulz. Not to mention all the database changes that go along with that.

 

Edit: The email handler for reports is working now too

Will the reserved slot feeder work as before? Or do i need to re-do my script?

 

If so, what are the changes?

 

*edit

Ah, didn't see your last answer there, any chance i can take a look at the new db structure?

 

*edit2

Is this up to date: https://github.com/ColColonCleaner/A...dev/adkats.sql ?

[Prophet731]

Originally Posted by Prophet731*:

 

Awesome news: looking forward to the new functions. DO you know if the old (1.0.3) webadmin will still work with 4.0?

 

PS: If you need another tester let me know.

Only version 1.0.3 will work with the old AdKats database. The 1.4 update will use the new AdKats database structure and won't be backwards compatable. Colon or me will have to write up a conversation script to merge all the data. Also, 1.4 will only work with the new logger plugin table structure as multi games can be run on it so you no longer will need two separate databases.

[Prophet731]

Originally Posted by Prophet731*:

 

Will the reserved slot feeder work as before? Or do i need to re-do my script?

 

If so, what are the changes?

 

*edit

Ah, didn't see your last answer there, any chance i can take a look at the new db structure?

 

*edit2

Is this up to date: https://github.com/ColColonCleaner/A...dev/adkats.sql ?

Yes

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Will the reserved slot feeder work as before? Or do i need to re-do my script?

 

If so, what are the changes?

 

*edit

Ah, didn't see your last answer there, any chance i can take a look at the new db structure?

 

*edit2

Is this up to date: https://github.com/ColColonCleaner/A...dev/adkats.sql ?

For your purposes yes, that will be the final version. A couple tweaks still need to be made but they should not affect the user system directly. All users in the user list will get the slots, so create a user for each of them, then assign those users the appropriate soldiers and roles. Users can have multiple soldiers now, and all soldiers under a user receive the same treatment.

 

You could create a user named "ReservedSlots" to keep things simple, or something along those lines. Assign that user the "Default Guest" role (that should happen automatically), and just add all soldiers you want slotted to that user.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Yes

Such a helpful post prophet

[Prophet731]

Originally Posted by Prophet731*:

 

Such a helpful post prophet

I try.

[ImportBot]

Originally Posted by TMiland*:

 

For your purposes yes, that will be the final version. A couple tweaks still need to be made but they should not affect the user system directly. All users in the user list will get the slots, so create a user for each of them, then assign those users the appropriate soldiers and roles. Users can have multiple soldiers now, and all soldiers under a user receive the same treatment.

 

You could create a user named "ReservedSlots" to keep things simple, or something along those lines. Assign that user the "Default Guest" role (that should happen automatically), and just add all soldiers you want slotted to that user.

This sounds like i will be staying on the version i already have, this is too confusing for me, and i have already spent a lot of time making this system work.

 

Only fix i need is the !punish twice bug, if that's possible to add to the adkats version i am running now?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

This sounds like i will be staying on the version i already have, this is too confusing for me, and i have already spent a lot of time making this system work.

 

Only fix i need is the !punish twice bug, if that's possible to add to the adkats version i am running now?

Or i could just add another table for reserved slots to make things simple . All users on the user list still get reserved slots, but also the people from this extra table. It will just be one column. adkats_reservedslots player_name.