Advanced In-Game Admin and Ban Enforcer - AdKats

[ImportBot]

Originally Posted by dmmaciag*:

 

Understood, I'll take a look at that in the morning and let you know.

[ImportBot]

Originally Posted by dmmaciag*:

 

Do a db query for any records in your adkats_records_main table with adkats_read = N

 

If you have any, remove them.

 

If not, i'm surprised this hasn't come up in the 2.5M records our servers have issued.

 

I'm adding a patch so that it won't happen even in that weird edge case, however i'm mid dev on the ping limiter ticket so i can't upload it right now.

Sure enough, I went in and found two entries with "N". I have deleted them and all is well in the land of AdKats. I put the new version back in and launched it. Debug level was set to 5. During startup I noticed this in the console:

 

[09:45:16 81] [AdKats] SQL updates found. Parsing...

[09:45:16 81] [AdKats] Parsing SQL Update 'command57adminfix'

[09:45:16 81] [AdKats] SQL update 'command57adminfix' version_minimum: 5.0.0.0

[09:45:16 81] [AdKats] SQL update 'command57adminfix' version_maximum:

[09:45:16 81] [AdKats] SQL update 'command57adminfix' message_name: Fix command 57 admin-only status

[09:45:16 81] [AdKats] SQL update 'command57adminfix' message_success: Command 57 admin-only status fixed

[09:45:16 81] [AdKats] SQL update 'command57adminfix' message_failure: Failed to fix command 57 admin-only status

[09:45:16 81] [AdKats] SQL update 'command57adminfix' update_checks: 2

[09:45:16 81] [AdKats] SQL update 'command57adminfix' update_execute_requiresModRows: True

[09:45:16 81] [AdKats] SQL update 'command57adminfix' update_execute: 1

[09:45:16 81] [AdKats] SQL update 'command57adminfix' update_success: 0

[09:45:16 81] [AdKats] SQL update 'command57adminfix' update_failure: 0

[09:45:17 10] [AdKats] Cancelling SQL update 'command57adminfix'. Update failed initial conditions.

Also, I didn't see anything about manually adding admin assistants in the settings, or is that because that SQL update failed?

 

EDIT: For the sake of not spamming, I noticed something just now. Using the @admin command can call an admin, but it sends a report email as if a player had been reported. Is it intended for both @admin and @report to serve the same function?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Sure enough, I went in and found two entries with "N". I have deleted them and all is well in the land of AdKats. I put the new version back in and launched it. Debug level was set to 5. During startup I noticed this in the console:

 

 

 

Also, I didn't see anything about manually adding admin assistants in the settings, or is that because that SQL update failed?

 

EDIT: For the sake of not spamming, I noticed something just now. Using the @admin command can call an admin, but it sends a report email as if a player had been reported. Is it intended for both @admin and @report to serve the same function?

1. Glad you found it. Adding records manually is not a good idea in invalid cases. I'll make sure that can't happen anymore for the kick records though.

2. That is a normal SQL update, if it failed initial conditions it just means it doesn't apply to your database. SQL updates only apply in some cases.

3. There is a new command, aawhitelist.

4. report and admin are basically the same command with different names. This is because so many servers run different configurations, and on some it's report to report a player, and on others its admin to report a player. This just makes it so they both work the same. That said, if you really want your admin command to be just a message to admins. Rename the admin command text something random, then change the adminmsg command text to admin.

[ImportBot]

Originally Posted by dmmaciag*:

 

1. Glad you found it. Adding records manually isn't a good idea.

2. That is a normal SQL update, if it failed initial conditions it just means it doesn't apply to your database. SQL updates only apply in some cases.

3. There is a new command, aawhitelist.

4. report and admin are basically the same command with different names. This is because so many servers run different configurations, and on some it's report to report a player, and on others its admin to report a player. This just makes it so they both work the same. That said, if you really want your admin command to be just a message to admins. Rename the admin command text something random, then change the adminmsg command text to admin.

I understand now, cool. Thanks!

 

EDIT: Was just thinking about what we discussed before about making it an option for emails not to send if admins are online. Would that also pertain to AA? If an AA is online would a report email not be sent?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

I understand now, cool. Thanks!

 

EDIT: Was just thinking about what we discussed before about making it an option for emails not to send if admins are online. Would that also pertain to AA? If an AA is online would a report email not be sent?

I can add another option for that, sure, but it wouldn't be the default as those players are not technically admins.

 

I'll also update the SQL update debug messages to be more understandable like "This update doesn't apply to this database" instead of just spitting out debug like "Failed initial conditions".

[ImportBot]

Originally Posted by dmmaciag*:

 

I can add another option for that, sure, but it wouldn't be the default as those players are not technically admins.

 

I'll also update the SQL update debug messages to be more understandable like "This update doesn't apply to this database" instead of just spitting out debug like "Failed initial conditions".

Up to you, we're happy either way. Have started testing the AA function and all is good so far

[ImportBot]

Originally Posted by Fonta*:

 

Just came accros an little thing.

Whenever I enable the plugin, it starts spamming admin.listPlayers all in the console which makes procon unresponsive.

It takes a while and will stop on a sudden moment, maybe when the ingame commands are loaded?

Could you take a look at this?

http://i.imgur.com/q1mm7mN.png

 

and here it finally stopped:

http://i.imgur.com/P8rbqRh.png

 

In chat:

http://i.imgur.com/tE464cx.png

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Just came accros an little thing.

Whenever I enable the plugin, it starts spamming admin.listPlayers all in the console which makes procon unresponsive.

It takes a while and will stop on a sudden moment, maybe when the ingame commands are loaded?

Could you take a look at this?

http://i.imgur.com/q1mm7mN.png

 

and here it finally stopped:

http://i.imgur.com/P8rbqRh.png

 

In chat:

http://i.imgur.com/tE464cx.png

Unless there is a bug i have not seen, the fastest interval player list is called is once every 10 seconds in normal operation, and slightly faster if you have people queued to switch teams. I'll look into it.

 

Edit: I found out why, it's because of a change I made to the startup process. Thanks for bringing this to my attention.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

TESTERS ONLY

The long lasting issue with "XpKiller's tables not found" after changing databases without restarting procon has been fixed.

If your database UTC time and procon layer UTC time are mismatched by over 5 minutes, it will not allow AdKats to start. Override provided, but time sensitive commands like punish are disallowed if override active.

Fixed commands with logging marked "unable" still being logged.

Added tban2days and tban3days to punishment options.

Released ping enforcer publicly.

Released commander manager publicly.

If a player reports someone recently kicked or banned, it tells them the player has already been removed, and cancels the report.

Added surrender and votenext commands, BUT THEY DO NOT WORK YET, don't use them.

Modified the admin responses for self_rules command to be more helpful.

 

If someone could test 5.1.4.7 for this functionality that would be great.

 

https://raw.githubusercontent.com/Co...test/AdKats.cs

[ImportBot]

Originally Posted by dmmaciag*:

 

TESTERS ONLY

The long lasting issue with "XpKiller's tables not found" after changing databases without restarting procon has been fixed.

If your database UTC time and procon layer UTC time are mismatched by over 5 minutes, it will not allow AdKats to start. Override provided, but time sensitive commands like punish are disallowed if override active.

Fixed commands with logging marked "unable" still being logged.

Added tban2days and tban3days to punishment options.

Released ping enforcer publicly.

Released commander manager publicly.

If a player reports someone recently kicked or banned, it tells them the player has already been removed, and cancels the report.

Added surrender and votenext commands, BUT THEY DO NOT WORK YET, don't use them.

Modified the admin responses for self_rules command to be more helpful.

 

If someone could test 5.1.4.7 for this functionality that would be great.

 

https://raw.githubusercontent.com/Co...test/AdKats.cs

Does this include the changes with the AA that we're testing?

[Prophet731]

Originally Posted by Prophet731*:

 

Colon, can your upgrade script do database changes as well? I've made a change to the tbl_chatlog table to add an index on the logDate column. It helped increase the speed of searching the chatlog table by datetimes from 3 seconds down to under 500ms on the query I ran.

 

This is the query that needs to be ran.

 

Code:

ALTER TABLE `tbl_chatlog` ADD INDEX (logDate);

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Does this include the changes with the AA that we're testing?

Yes, this is in comparison to the last test post i made. The changes from 5.1.0.0 - 5.1.4.7 is much larger.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Colon, can your upgrade script do database changes as well? I've made a change to the tbl_chatlog table to add an index on the logDate column. It helped increase the speed of searching the chatlog table by datetimes from 3 seconds down to under 500ms on the query I ran.

 

This is the query that needs to be ran.

 

Code:

ALTER TABLE `tbl_chatlog` ADD INDEX (logDate);

That's what the adkatsupdates.json is for. Look in there for the structure and post a block i can add to it.

[ImportBot]

Originally Posted by durangod*:

 

sorry i need to learn to read lol lmao it was just asked

 

thanks

[Prophet731]

Originally Posted by Prophet731*:

 

That's what the adkatsupdates.json is for. Look in there for the structure and post a block i can add to it.

So like this?

 

Code:

{    "SQLUpdates":[
        {
            "update_id":"addIndexToChatlogTable",
            "version_minimum":"5.0.0.0",
            "version_maximum":null,
            "message_name":"Adds an index to the logDate column in tbl_chatlog for increase speed",
            "message_success":"Index succesfully added",
            "message_failure":"Failed to added index to tbl_chatlog",
            "update_checks":[],
            "update_execute_requiresModRows":true,
            "update_execute":[
                "ALTER TABLE `tbl_chatlog` ADD INDEX (logDate);"
            ],
            "update_success":[],
            "update_failure":[]
        }
    ]
}

[ImportBot]

Originally Posted by LumPenPacK*:

 

Hi ColColonCleaner,

is there an option to disable this first join messages?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

So like this?

 

Code:

{    "SQLUpdates":[
        {
            "update_id":"addIndexToChatlogTable",
            "version_minimum":"5.0.0.0",
            "version_maximum":null,
            "message_name":"Adds an index to the logDate column in tbl_chatlog for increase speed",
            "message_success":"Index succesfully added",
            "message_failure":"Failed to added index to tbl_chatlog",
            "update_checks":[],
            "update_execute_requiresModRows":true,
            "update_execute":[
                "ALTER TABLE `tbl_chatlog` ADD INDEX (logDate);"
            ],
            "update_success":[],
            "update_failure":[]
        }
    ]
}

You need a check for validity. Add a query that will return rows if the update should be executed. Otherwise its good.

 

EDIT: I might need to add a field for saying the checks should/shouldn't return rows to be valid for the update.

 

EDIT: Added. https://raw.githubusercontent.com/Co...tsupdates.json

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Hi ColColonCleaner,

is there an option to disable this first join messages?

Download the test version. Section A12.

[ImportBot]

Originally Posted by durangod*:

 

Hi,

 

i have it all installed and everything seems to be working, however im a bit confused here.

 

1. Which process are my admins going to log into, the default admin or this admin?

 

2. I seem to be creating users for ADKats but where do they log into - i mean doesnt the procon go off their game name just as the other admin did but yet i dont see anywhere to put their gamename on this admin?

 

3. I also dont see anywhere to set a pw for them, how do they log in?

 

4. I dont see any kind of interface for the stats like a display, do i have to build my own php files to display the info from the db for this or is there a stats interface that i am not seeing?

 

5. I assume if they are online their name will be green in the account section right?

 

Thanks

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Hi,

 

i have it all installed and everything seems to be working, however im a bit confused here.

 

1. Which process are my admins going to log into, the default admin or this admin?

 

2. I seem to be creating users for ADKats but where do they log into - i mean doesnt the procon go off their game name just as the other admin did but yet i dont see anywhere to put their gamename on this admin?

 

3. I also dont see anywhere to set a pw for them, how do they log in?

 

4. I dont see any kind of interface for the stats like a display, do i have to build my own php files to display the info from the db for this or is there a stats interface that i am not seeing?

 

5. I assume if they are online their name will be green in the account section right?

 

Thanks

Ok, almost all of your questions are about people logging in, which is strange because a large portion of the control is done in-game.

 

 

• The process they log into is battlefield, their soldiers are their log in. When they come into your servers they have access.
• Each user is assigned a soldier, or list of soldiers. Those soldiers have access in-game to the commands you assign to their role. You can see the "Add Soldier" line under their user. If you use their in-game name as their user name, the soldier is automatically added when you create the user.
• Procon accounts do not apply to users in AdKats (yet, im planning on adding that later), this means you don't need to create a procon account for each user, just add them in AdKats settings.
• BFAdminCP is the web interface for AdKats (Example: https://gcp.adkgamers.com/), and a major update is being pushed soon. You don't need to make any of your own files. If you view a player's profile it will show you all the sessions of time they were online in your servers, not to mention a lot of other useful stats and logs.
• You can see all online admins with the /admins command. Please review the AdKats command list.

Make sense?

[ImportBot]

Originally Posted by durangod*:

 

yes somewhat and ill know more once i get into the game and see whats what, but for item 3, when i create a user in adkats with special chars like ? in the gamename it gives warning on bottom of invalid name.

 

If i need to add the user to the adkats then how does adkats know that i want JohnWayne_Duke to be an admin which is my player name when i cant use ? and all i can do is create a username in adkats like JohnWayneDuke and how does the system know which user if i dont use their gamename in adkats.

 

i did make them an admin limited account, and told them to leave the basic admin ingame stats deactivated as we are using the new one now. So your saying that they dont even need to go in there for playerlists, maps or anything at all, they can do it all via inside the game now.

 

this is where i get this

https://github.com/Prophet731/BFAdmi...ter/server.php

 

i was looking for an install readme file for the bfadmincp but i dont see one.

[ImportBot]

Originally Posted by durangod*:

 

i am totally having a hard time with this whole deal. I have had to basically rebuild the tables for the bfadmincp and errors and stuff and still not working http://bfadmin.teamxrossfire.com/dashboard almost 4 15 hour days just to set up a server and get some idea of how to manage players, how long has gaming been around, this should be sooooo easy by now. Between doing this and that and reading about this and fixing that. It just wears you out.

 

so i went in the game and i typed !kill and then it told me that my default guest role was not auth to use that. Well im not def guest im admin, it says im admin on every screen, it even said admin on the message that told me i was not lmao.. So i have no clue how this is suppose to work and honestly im starting to think it all a bunch of huey... sorry im just very tired.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

i am totally having a hard time with this whole deal. I have had to basically rebuild the tables for the bfadmincp and errors and stuff and still not working http://bfadmin.teamxrossfire.com/dashboard almost 4 15 hour days just to set up a server and get some idea of how to manage players, how long has gaming been around, this should be sooooo easy by now. Between doing this and that and reading about this and fixing that. It just wears you out.

 

so i went in the game and i typed !kill and then it told me that my default guest role was not auth to use that. Well im not def guest im admin, it says im admin on every screen, it even said admin on the message that told me i was not lmao.. So i have no clue how this is suppose to work and honestly im starting to think it all a bunch of huey... sorry im just very tired.

It is easy, if you do it correctly. I do not control BFAdminCP, that's prophet. I noticed you posted about 12 replies to that thread without waiting for a response, maybe wait for him?

 

As for your user issue. Look at your user in AdKats. You don't have a soldier connected to it.

 

It should look like this:

 

[ImportBot]

Originally Posted by durangod*:

 

thanks i feel better after some much needed rest... yeah thats alot of messages oops... well i did finally get it going with 1.5 with some small tweeks in the sql install. So i am much happier now. yes mine does have a user but it dont show.

 

I think its because i got frustrated and deleted the default, then added it back. So instead of having

 

rec id 1 default and rec id 2 my name

its rec id 2 myname and rec id 3 default

 

so maybe thats why.

 

adkats.jpg

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

thanks i feel better after some much needed rest... yeah thats alot of messages oops... well i did finally get it going with 1.5 with some small tweeks in the sql install. So i am much happier now. yes mine does have a user but it dont show.

 

I think its because i got frustrated and deleted the default, then added it back. So instead of having

 

rec id 1 default and rec id 2 my name

its rec id 2 myname and rec id 3 default

 

so maybe thats why.

 

adkats.jpg

Wow, you can't just go editing things without knowing how they work. Please, just SLOW DOWN. default guest must be role id 1, with key "guest_default", do not edit the roles table manually unless you know what you are doing.

[ImportBot]

Originally Posted by TMiland*:

 

Hi, what are the changes regarding this: "All player orchestration in other plugins is done by player EAGUID now, instead of player name."

 

Seems that my custom reserved slots system is borked, and has been since i upgraded...

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Hi, what are the changes regarding this: "All player orchestration in other plugins is done by player EAGUID now, instead of player name."

 

Seems that my custom reserved slots system is borked, and has been since i upgraded...

This does not apply to reserved slots, only orchestration through other plugins. For example if you are feeding the multibalancer whitelist, it feeds based on player GUID now, instead of player name.

 

Reserved slots are still added by name, as that is required by the server, the server does not accept GUIDs for that list.

 

What version did you update to when this started happening?

[ImportBot]

Originally Posted by TMiland*:

 

Hmm, okay, looks like this started after upgrading to the official version.

 

This is how it looks in the db:

https://myrcon.net/recovered/img/110333_attachment.php_attachmentid3589ampd1413395002

 

Notice the dates...

 

I tried to remove me and re-add from the forum cp, and i am re-added to the db, but i don't appear in the slot list

 

Attached Files:

• WB8uAru.png

[ImportBot]

Originally Posted by TMiland*:

 

I have manually deleted and re-added all players to the db WITH dates, now it works...

 

There was also alot of duplicates... What could cause this?

[ImportBot]

Originally Posted by durangod*:

 

Wow, you can't just go editing things without knowing how they work. Please, just SLOW DOWN. default guest must be role id 1, with key "guest_default", do not edit the roles table manually unless you know what you are doing.

ok i will fix it