Advanced In-Game Admin and Ban Enforcer - AdKats

[ImportBot]

Originally Posted by durangod*:

 

fixed

 

adkats2.jpg

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Hmm, okay, looks like this started after upgrading to the official version.

 

This is how it looks in the db:

 

Notice the dates...

 

I tried to remove me and re-add from the forum cp, and i am re-added to the db, but i don't appear in the slot list

Exceptions in the plugin console? Can guarantee those invalid dates are causing problems. What invalidated those dates?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

I have manually deleted and re-added all players to the db WITH dates, now it works...

 

There was also alot of duplicates... What could cause this?

I don't modify entries in that table en-mass, there will be a record assigned to every change made.

 

What should be done when an invalid date is found? Ignore the line, or accept the line as a permanent entry?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

fixed

 

adkats2.jpg

Ok, now just add your soldier to your user. Type your IGN into your user's add soldier line.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Testers Only.

 

I added internal surrender system so it can be tracked, but it is completely untested. Can't test it for another few days.

 

The surrender vote system is coded, but the auto-surrender system is not, none of those settings will work.

 

https://raw.githubusercontent.com/Co...test/AdKats.cs

[ImportBot]

Originally Posted by TMiland*:

 

Exceptions in the plugin console? Can guarantee those invalid dates are causing problems. What invalidated those dates?

I have gone through every console log from 22.09, and nothing shows up... BUT i remember AdKats was complaining about something unknown, but not what exactly.

I don't modify entries in that table en-mass, there will be a record assigned to every change made.

 

What should be done when an invalid date is found? Ignore the line, or accept the line as a permanent entry?

Okay, well i am not sure...

 

I am testing to see now what happens when a user upgrade is made, the dates are just zero's when added...

 

 

I have no clue how to fix this.

[Prophet731]

Originally Posted by Prophet731*:

 

I have gone through every console log from 22.09, and nothing shows up... BUT i remember AdKats was complaining about something unknown, but not what exactly.

 

 

Okay, well i am not sure...

 

I am testing to see now what happens when a user upgrade is made, the dates are just zero's when added...

 

 

I have no clue how to fix this.

Dates will be zeros if an invalid date in sent.

[ImportBot]

Originally Posted by TMiland*:

 

Dates will be zeros if an invalid date in sent.

Thanks for your input, got my head around it now i hope!

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Thanks for your input, got my head around it now i hope!

What should be done for entries like these? Right now they cause the entire list to cancel posting.

[ImportBot]

Originally Posted by TMiland*:

 

What should be done for entries like these? Right now they cause the entire list to cancel posting.

Not sure, but this should not be a problem really, i think it's the forum software (xenforo) that have changed, so i need to update the custom code to the new user payment system in the latest version. (i hope)

[Prophet731]

Originally Posted by Prophet731*:

 

What should be done for entries like these? Right now they cause the entire list to cancel posting.

Throw it in a loop with a try .. catch and if a entry is invalid throw a warning referencing this record and then continue processing it. That start date is essentially the start of epoch time. All dates in the database should have the format of YYYY-MM-DD hh:mm:ss

 

This is how I could do it in PHP so it should be almost the same way for you.

 

Code:

<_php

foreach($query as $key => $row)
{
    try {
        
        if($row->date == '0000-00-00 00:00:00')
        {
            throw new Exception("Error Processing Request - Record failed to process" . $row->record_id);
            
        }


    } catch (Exception $e) {
        // Throw warning message to console
    }
}

This would still process the records as the try...catch doesn't stop the processing while in a loop.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Throw it in a loop with a try .. catch and if a entry is invalid throw a warning referencing this record and then continue processing it. That start date is essentially the start of epoch time. All dates in the database should have the format of YYYY-MM-DD hh:mm:ss

 

This is how I could do it in PHP so it should be almost the same way for you.

 

Code:

<_php

foreach($query as $key => $row)
{
    try {
        
        if($row->date == '0000-00-00 00:00:00')
        {
            throw new Exception("Error Processing Request - Record failed to process" . $row->record_id);
            
        }


    } catch (Exception $e) {
        // Throw warning message to console
    }
}

This would still process the records as the try...catch doesn't stop the processing while in a loop.

Just need to know the behavior people want, whether the entry should be ignored or assumed a permanent entry.

[Prophet731]

Originally Posted by Prophet731*:

 

Just need to know the behavior people want, whether the entry should be ignored or assumed a permanent entry.

Should be ignored. It's an invalid date.

[Prophet731]

Originally Posted by Prophet731*:

 

Also colon, add this to your update json file.

 

Code:

ALTER TABLE `adkats_records_main` ADD INDEX `adkats_records_main_fk_record_time` (`record_time` ASC);

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Whoever updated to TEST versions 5.1.5.0 - 5.1.5.2 should update to the latest test version immediately, there was an error that made records post without valid record_time.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Also colon, add this to your update json file.

 

Code:

ALTER TABLE `adkats_records_main` ADD INDEX `adkats_records_main_fk_record_time` (`record_time` ASC);

I'll work on that tomorrow.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

TEST version 5.1.5.5 has surrender vote and auto-surrender added. In need of testing .

[ImportBot]

Originally Posted by HappyGotLucky*:

 

Using /move, adkats sometimes goes crazy moving a player between both teams dozens of times. Any thoughts on why?

 

[02:52:58] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:52:58] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:52:58] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:58] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:59] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:52:59] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:52:59] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:59] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:01] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:01] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:01] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:01] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:02] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:02] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:02] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:02] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:03] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:03] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:03] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:03] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:04] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:04] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:04] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:04] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[ImportBot]

Originally Posted by Jasonpb*:

 

TEST version 5.1.5.5 has surrender vote and auto-surrender added. In need of testing .

I'll give it a go and let you know

[ImportBot]

Originally Posted by Jasonpb*:

 

Works fine, didn't try auto but the standard one works.

 

Also used your ping kicker!

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Using /move, adkats sometimes goes crazy moving a player between both teams dozens of times. Any thoughts on why?

 

[02:52:58] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:52:58] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:52:58] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:58] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:59] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:52:59] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:52:59] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:52:59] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:01] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:01] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:01] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:01] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:02] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:02] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:02] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:02] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:03] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:03] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:03] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:03] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:04] AdKats > dj24957jr2 attempted to team switch after being admin moved.

[02:53:04] AdKats > Say > iwantyourskullx > dj24957jr2 attempted to team switch after being admin moved.

[02:53:04] AdKats > Say > dj24957jr2 > You were moved to RU team, please remain on that team.

[02:53:04] AdKats > Yell[5] > dj24957jr2 > You were moved to RU team, please remain on that team.

Looks like it's fighting with your autobalancer, your autobalancer is moving them back to the previous team, which is not allowed after an admin move.

 

AdKats blocks people from moving off of the team you moved them to, for the given round they are locked to that team unless you move them again. It can't detect the difference between an autobalance move vs a player move, so it's denying them from moving off that team.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Works fine, didn't try auto but the standard one works.

 

Also used your ping kicker!

Auto-surrender will require some playing around with. It works very well on our metro server, so i'm anxious to see how it works with others.

 

If you want to test it out, first enable ticket rate display in procon chat, it's in the messaging section. That will display the ticket loss/gain rates of your teams in the procon chat tab, in tickets per minute. Monitor what values it displays during unrecoverable baserape, that is when you want auto-surrender to trigger. You can set the winning and losing rate windows to contain the values you find in your tests. When the winning team and losing team fall into the appropriate windows, auto-surrender will fire.

[ImportBot]

Originally Posted by TMiland*:

 

Throw it in a loop with a try .. catch and if a entry is invalid throw a warning referencing this record and then continue processing it. That start date is essentially the start of epoch time. All dates in the database should have the format of YYYY-MM-DD hh:mm:ss

 

This is how I could do it in PHP so it should be almost the same way for you.

 

Code:

<_php

foreach($query as $key => $row)
{
    try {
        
        if($row->date == '0000-00-00 00:00:00')
        {
            throw new Exception("Error Processing Request - Record failed to process" . $row->record_id);
            
        }


    } catch (Exception $e) {
        // Throw warning message to console
    }
}

This would still process the records as the try...catch doesn't stop the processing while in a loop.

Hmm, what i dont get is why it suddenly stopped adding the dates, or adding them as zero's, and i dont get where it's supposed to get the dates from...

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Ok, changes made to the auto-surrender. Some of the settings were not working properly.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Hmm, what i dont get is why it suddenly stopped adding the dates, or adding them as zero's, and i dont get where it's supposed to get the dates from...

Make sure you are not running AdKats 5.1.5.0 - 5.1.5.3. If so, update to the latest test version immediately.

 

Were you adding these people using an external script, or using plugin commands?

[ImportBot]

Originally Posted by Jasonpb*:

 

With auto surrender, does it just prompt people to vote, or does it actually surrender?

 

Also I'm not sure if I've broken something but upon banning players they are no longer being kicked from the game, have to manually kick them.

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

With auto surrender, does it just prompt people to vote, or does it actually surrender?

 

Also I'm not sure if I've broken something but upon banning players they are no longer being kicked from the game, have to manually kick them.

It completes the surrender. People love it on our metro server, especially for those matches where autobalance messes up and baserape starts early, people don't need to sit through the round.

 

Do you mean banning them using in-game commands, or through the web admin?

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

TEST version 5.1.5.9 has an internal SpamBot. The benefit of this system is that it can ignore admins for the spam messages yet still message everyone else, so the admin's chat isn't cluttered. Also, it can send messages using say, yell, and tell. Needs testing.

[ImportBot]

Originally Posted by Jasonpb*:

 

TEST version 5.1.5.9 has an internal SpamBot. The benefit of this system is that it can ignore admins for the spam messages yet still message everyone else, so the admin's chat isn't cluttered. Also, it can send messages using say, yell, and tell. Needs testing.

Awesome!

 

Banning from in-game, grabbed a debug.

 

Code:

[07:10:29 82] [AdKats] FetchRecentRecords starting![07:10:29 82] [AdKats] databaseConnectionActive starting!
[07:10:29 82] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 82] [AdKats] databaseConnectionActive finished!
[07:10:29 82] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 82] [AdKats] FetchRecentRecords finished!
[07:10:29 82] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 84] [AdKats] KushOrKick's reputation updated from 0 to -47.62
[07:10:29 84] [AdKats] Entering playerSayMessage
[07:10:29 84] [AdKats] Entering handleChat
[07:10:29 84] [AdKats] Entering queueMessageForParsing
[07:10:29 84] [AdKats] Preparing to queue message for parsing
[07:10:29 84] [AdKats] Message queued for parsing.
[07:10:29 84] [AdKats] Exiting queueMessageForParsing
[07:10:29 84] [AdKats] MESSAGE: Entering Messaging Thread Loop
[07:10:29 84] [AdKats] Exiting handleChat
[07:10:29 84] [AdKats] MESSAGE: Preparing to lock messaging to retrive new messages
[07:10:29 84] [AdKats] MESSAGE: Inbound messages found. Grabbing.
[07:10:29 84] [AdKats] MESSAGE: begin reading message
[07:10:29 84] [AdKats] MESSAGE: Message is regular chat. Ignoring.
[07:10:29 84] [AdKats] MESSAGE: Entering Messaging Thread Loop
[07:10:29 84] [AdKats] MESSAGE: No inbound messages. Waiting for Input.
[07:10:29 90] [AdKats] Exiting playerSayMessage
[07:10:29 90] [AdKats] player_ban_perm update for KushOrKick by PlayerAdmin SUCCESSFUL!
[07:10:29 90] [AdKats] UpdateInnerRecord finished!
[07:10:29 90] [AdKats] DBCOMM: Update success. Record does not need action handling.
[07:10:29 90] [AdKats] In-Game/Automated player_ban_perm record took 281.2487ms to complete.
[07:10:29 90] [AdKats] DBCOMM: Entering Database Comm Thread Loop
[07:10:29 90] [AdKats] Skipping server ID fetch. Server ID: 25
[07:10:29 90] [AdKats] DBCOMM: Skipping DB action fetch
[07:10:29 90] [AdKats] DBCOMM: No inbound user changes.
[07:10:29 90] [AdKats] fetchNameBanCount starting!
[07:10:29 90] [AdKats] databaseConnectionActive starting!
[07:10:29 90] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 90] [AdKats] databaseConnectionActive finished!
[07:10:29 90] [AdKats] fetchGUIDBanCount starting!
[07:10:29 90] [AdKats] databaseConnectionActive starting!
[07:10:29 90] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 90] [AdKats] databaseConnectionActive finished!
[07:10:29 90] [AdKats] fetchIPBanCount starting!
[07:10:29 90] [AdKats] databaseConnectionActive starting!
[07:10:29 90] [AdKats] MySql Connection capable. All variables in place.
[07:10:29 90] [AdKats] databaseConnectionActive finished!
[07:10:29 90] [AdKats] DBCOMM: No unprocessed records. Waiting for input
[07:10:30 17] [AdKats] Entering OnPlayerKilled
[07:10:30 17] [AdKats] Entering queueKillForProcessing
[07:10:30 17] [AdKats] Preparing to queue kill for processing
[07:10:30 17] [AdKats] Kill queued for processing
[07:10:30 17] [AdKats] Exiting queueKillForProcessing
[07:10:30 17] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:30 17] [AdKats] Exiting OnPlayerKilled
[07:10:30 17] [AdKats] KILLPROC: Preparing to lock inbound kill queue to retrive new player kills
[07:10:30 17] [AdKats] KILLPROC: Inbound kills found. Grabbing.
[07:10:30 17] [AdKats] KILLPROC: begin reading player kills
[07:10:30 17] [AdKats] uploadWeaponCode starting!
[07:10:30 17] [AdKats] databaseConnectionActive starting!
[07:10:30 17] [AdKats] MySql Connection capable. All variables in place.
[07:10:30 17] [AdKats] databaseConnectionActive finished!
[07:10:30 17] [AdKats] Setting WALLE69 time of death to 10/17/2014 4:10:30 PM
[07:10:30 17] [AdKats] Exiting OnPlayerKilled
[07:10:30 17] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:30 17] [AdKats] KILLPROC: No inbound player kills. Waiting for Input.
[07:10:30 96] [AdKats] Entering OnPlayerKilled
[07:10:30 96] [AdKats] Entering queueKillForProcessing
[07:10:30 96] [AdKats] Preparing to queue kill for processing
[07:10:30 96] [AdKats] Kill queued for processing
[07:10:30 96] [AdKats] Exiting queueKillForProcessing
[07:10:30 96] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:30 96] [AdKats] Exiting OnPlayerKilled
[07:10:30 96] [AdKats] KILLPROC: Preparing to lock inbound kill queue to retrive new player kills
[07:10:30 96] [AdKats] KILLPROC: Inbound kills found. Grabbing.
[07:10:30 98] [AdKats] KILLPROC: begin reading player kills
[07:10:30 98] [AdKats] uploadWeaponCode starting!
[07:10:30 98] [AdKats] databaseConnectionActive starting!
[07:10:30 98] [AdKats] MySql Connection capable. All variables in place.
[07:10:30 98] [AdKats] databaseConnectionActive finished!
[07:10:30 98] [AdKats] Setting erikcaleb time of death to 10/17/2014 4:10:30 PM
[07:10:30 98] [AdKats] Exiting OnPlayerKilled
[07:10:30 98] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:30 98] [AdKats] KILLPROC: No inbound player kills. Waiting for Input.
[07:10:31 10] [AdKats] Entering OnPlayerSpawned
[07:10:31 10] [AdKats] Exiting OnPlayerSpawned
[07:10:32 84] [AdKats] Entering OnPlayerKilled
[07:10:32 84] [AdKats] Entering queueKillForProcessing
[07:10:32 84] [AdKats] Preparing to queue kill for processing
[07:10:32 84] [AdKats] Kill queued for processing
[07:10:32 84] [AdKats] Exiting queueKillForProcessing
[07:10:32 84] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:32 84] [AdKats] Exiting OnPlayerKilled
[07:10:32 84] [AdKats] KILLPROC: Preparing to lock inbound kill queue to retrive new player kills
[07:10:32 84] [AdKats] KILLPROC: Inbound kills found. Grabbing.
[07:10:32 84] [AdKats] KILLPROC: begin reading player kills
[07:10:32 84] [AdKats] uploadWeaponCode starting!
[07:10:32 84] [AdKats] databaseConnectionActive starting!
[07:10:32 84] [AdKats] MySql Connection capable. All variables in place.
[07:10:32 84] [AdKats] databaseConnectionActive finished!
[07:10:32 84] [AdKats] Setting InsanityInducer time of death to 10/17/2014 4:10:32 PM
[07:10:32 84] [AdKats] Exiting OnPlayerKilled
[07:10:32 84] [AdKats] KILLPROC: Entering Kill Processing Thread Loop
[07:10:32 84] [AdKats] KILLPROC: No inbound player kills. Waiting for Input.
[07:10:33 54] [AdKats] Entering OnPlayerSpawned
[07:10:33 54] [AdKats] Exiting OnPlayerSpawned
[07:10:33 98] [AdKats] MySql Connection capable. All variables in place.
[07:10:33 98] [AdKats] round stat pushed to database

[ColColonCleaner]

Originally Posted by ColColonCleaner*:

 

Awesome!

 

Banning from in-game, grabbed a debug.

If you watch the procon chat tab, does it say X has been BANNED, etc, etc